Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill_db.ts to fill all indices #498

Merged

Conversation

acarbonetto
Copy link
Collaborator

Issue #, if available:

N/A

Description of changes:

When running fill_database function, we were pushing data more than once into the database at key.

Observed keys to set by adding a console.log(key) at line 24 of fill_db.ts.

~/git/bq/babushka/benchmarks> ./install_and_test.sh -no-tls
/opt/homebrew/bin/python3

up to date, audited 18 packages in 233ms

found 0 vulnerabilities

> [email protected] flush
> node flush_db.js --host localhost

Flushing localhost

> [email protected] fill
> node fill_db.js --dataSize 100 --host localhost

Filling localhost with data size 100
0
0
0
... repeat x1000
1001
1001
1001
... repeat x1000
etc

Expected:

0
1000
2000
3000
4000
5000
6000
7000
8000
9000
10000
11000
12000
13000
14000
15000
16000
17000
18000
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shachlanAmazon shachlanAmazon merged commit 10e7017 into valkey-io:main Oct 5, 2023
1 check passed
@acarbonetto acarbonetto deleted the benchmarks/fix_filldb_index branch October 5, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants