added hexists command in node. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/src/BaseClient.ts
Outdated
| * | ||
| * @param key - The key of the hash. | ||
| * @param field - The field to check in the hash stored at key. | ||
| * @returns 1 if the hash contains field. 0 if the hash does not contain field, or key does not exist. |
There was a problem hiding this comment.
key does not exist is... what? an exception? a string?
if it's an exception, it isn't returned, it's thrown. do we have such an exception?
adanWattad
force-pushed
the
node/hexist
branch
from
ee8ba21 to
cc3c575
Compare
adanWattad
force-pushed
the
node/hexist
branch
from
cc3c575 to
4b99d20
Compare
barshaul
reviewed
Oct 11, 2023
node/src/BaseClient.ts
Outdated
| * | ||
| * @param key - The key of the hash. | ||
| * @param field - The field to check in the hash stored at key. | ||
| * @returns 1 if the hash contains field. If the hash does not contain the field, or if the key does not exist, it returns 0. |
There was a problem hiding this comment.
* @returns 1 if the hash contains `field`. If the hash does not contain `field`, or if `key` does not exist, returns 0.
Make sure to use `` on variable names
barshaul
reviewed
Oct 11, 2023
node/src/Transaction.ts
Outdated
| * @param key - The key of the hash. | ||
| * @param field - The field to check in the hash stored at key. | ||
| * | ||
| * Command Response - 1 if the hash contains field. If the hash does not contain the field, or if the key does not exist, |
barshaul
reviewed
Oct 11, 2023
node/tests/SharedTests.ts
Outdated
| const nonExistingKey = uuidv4(); | ||
| const field1 = uuidv4(); | ||
| const field2 = uuidv4(); | ||
| const nonExistingField = uuidv4(); |
There was a problem hiding this comment.
You don't need to generate random uuids for values / non existing fields if they don't change the database/not being tested, you can use simple strings instead, e.g.:
const key = uuidv4();
const field1 = uuidv4();
const field2 = uuidv4();
const fieldValueMap = {
[field1]: "value1",
[field2]: "value2",
};
expect(await client.hset(key, fieldValueMap)).toEqual(2);
expect(await client.hexists(key, field1)).toEqual(1);
expect(await client.hexists(key, "non-existing-filed")).toEqual(0);
expect(await client.hexists("non-existing-key", field2)).toEqual(0);
We use random strings for keys to make sure that if we run multiple tests at the same time, we don't accidentally use the same keys in different tests to prevent one test from messing with another. So if there's no risk of collision you can use simple strings
adanWattad
force-pushed
the
node/hexist
branch
2 times, most recently
from
b882338 to
a4ca89f
Compare
adanWattad
force-pushed
the
node/hexist
branch
from
a4ca89f to
afbd632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added hexists command in node.