added clientId command in node #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/src/RedisClusterClient.ts
Outdated
| * case the client will initially try to route the command to the nodes defined by `route`. | ||
| * @returns the id of the client. | ||
| */ | ||
| public clientId(route?: Routes): Promise<number | [string, number][]> { |
There was a problem hiding this comment.
rebase and use ClusterResponse<number>
| @@ -175,4 +176,18 @@ export class RedisClusterClient extends BaseClient { | |||
| toProtobufRoute(route) | |||
| ); | |||
| } | |||
|
|
|||
| /** Returns the current connection id. | |||
There was a problem hiding this comment.
should the documentation explain that since connections might disconnect and reconnect, and since the command might be routed differently between calls, the result isn't promised to remain constant?
@barshaul
adanWattad
force-pushed
the
node/clientId
branch
3 times, most recently
from
ce1d98c to
c0ea4c0
Compare
|
please rebase |
adanWattad
force-pushed
the
node/clientId
branch
4 times, most recently
from
b7e58bf to
6ddf1a0
Compare
node/src/RedisClusterClient.ts
Outdated
| * @param route - The command will be routed automatically, unless `route` is provided, in which | ||
| * case the client will initially try to route the command to the nodes defined by `route`. | ||
| * @returns the id of the client. When specifying a route other than a single node, | ||
| * the response will be a dictionary of Address: nodeResponse. |
There was a problem hiding this comment.
a dictionary of Address: nodeResponse is neither english, nor types.
adanWattad
force-pushed
the
node/clientId
branch
from
6ddf1a0 to
260d3ba
Compare
shachlanAmazon
approved these changes
Oct 4, 2023
adanWattad
force-pushed
the
node/clientId
branch
from
260d3ba to
8fef3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added clientId command in node.