added clientGetName command- Node #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing the expected response/request policy |
adanWattad
force-pushed
the
node/clientGet+Set
branch
2 times, most recently
from
9271901 to
1981af9
Compare
|
@barshaul @adanWattad @shohamazon the CLIENT SETNAME command might be more complex than expected, since we'll need to reset the name when we reconnect internally. I suggest not implementing it in code for now, instead passing the value in the connection options. |
|
I recommend that we only implement CLIENT GETNAME for now |
adanWattad
force-pushed
the
node/clientGet+Set
branch
from
1981af9 to
eb3d9bc
Compare
adanWattad
changed the title
node/src/Transaction.ts
Outdated
| * See https://redis.io/commands/client-getname/ for more details. | ||
| * | ||
| * Command Response - the name of the client connection as a string if a name is set, or null if no name is assigned. | ||
| * When specifying a route other than a single node, the response will be a dictionary of Address: nodeResponse. |
There was a problem hiding this comment.
there's no route with more than a single node in a transaction.
node/src/RedisClusterClient.ts
Outdated
| * case the client will initially try to route the command to the nodes defined by `route`. | ||
| * | ||
| * @returns - the name of the client connection as a string if a name is set, or null if no name is assigned. | ||
| * When specifying a route other than a single node, it will return a dictionary of Address: nodeResponse. |
There was a problem hiding this comment.
a dictionary of Address: nodeResponse is neither english, nor a description of the returned typed.
adanWattad
force-pushed
the
node/clientGet+Set
branch
from
eb3d9bc to
57ccb99
Compare
shachlanAmazon
approved these changes
Oct 4, 2023
acarbonetto
added a commit
that referenced
this pull request
Jun 25, 2024
* Python: Add LOLWUT command (#387) Added Python LOLWUT command * Updated CHANGELOG.md * Fixed formated issues --------- Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added clientGetName and clientSetName commands in node.
response/request policy: None.