Go: Add command ZScan #2950
Open
Go: Add command ZScan #2950
+292
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TJ Zhang <[email protected]>
tjzhang-BQ
force-pushed
the
go/tjz-zscan
branch
from
8d058cc to
38d5844
Compare
| @@ -1630,3 +1630,28 @@ func (client *baseClient) XLen(key string) (Result[int64], error) { | |||
| } | |||
| return handleLongResponse(result) | |||
| } | |||
|
|
|||
| func (client *baseClient) ZScan(key string, cursor string) (Result[string], []Result[string], error) { | |||
There was a problem hiding this comment.
Move docs there please
Comment on lines
+24
to
+29
| func (zScanOptions *ZScanOptions) SetMatch(match string) *ZScanOptions { | ||
| zScanOptions.BaseScanOptions.SetMatch(match) | ||
| return zScanOptions | ||
| } | ||
|
|
||
| func (zScanOptions *ZScanOptions) SetCount(count int64) *ZScanOptions { |
There was a problem hiding this comment.
Add docs to these methods
Comment on lines
+1250
to
+1251
| fmt.Println("_____________________") | ||
| fmt.Println(resCollection) |
| if err != nil { | ||
| return CreateNilStringResult(), nil, err | ||
| } | ||
| return handleScanResponse(result) |
There was a problem hiding this comment.
Could you update please handleScanResponse to return (string, []string, error)? Those strings are never nil.
You can do it in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2878
Checklist
Before submitting the PR make sure the following are checked: