Some pointer shenanigans. #2895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.77 introduced C-string literals, which allows us to use static C-strings, instead of going through CString and allocating a new string on every invocation. https://doc.rust-lang.org/edition-guide/rust-2021/c-string-literals.html Signed-off-by: Shachar Langbeheim <[email protected]>
https://doc.rust-lang.org/std/ptr/fn.from_mut.html This is recommended as a safer alternative to `as` casts, since they provide some type checking. Notice that the caveat in the docs isn't relevant here, since the function is called exclusively over leaked boxes, which don't have a bounded lifetime. Signed-off-by: Shachar Langbeheim <[email protected]>
Signed-off-by: Shachar Langbeheim <[email protected]>
nihohit
force-pushed
the
pointer-shenanigans
branch
from
6f86fcf to
d5e76f8
Compare
Signed-off-by: Shachar Langbeheim <[email protected]>
nihohit
force-pushed
the
pointer-shenanigans
branch
from
d19ca6c to
c7dca4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to use newer pointer/C-string APIs that weren't available when the repo was created, in order to make the handling of raw pointers slightly safer.
This change is only a partial change - hopefully I'll have time to go over more of the pointer conversions and double check them.
This is in preparation of the pointer provenance change that will hopefully land in the next Rust release, which will allow for even better safety in handling pointers.
Checklist
Before submitting the PR make sure the following are checked: