Go: ZREM.
#2880
Merged
Go: ZREM.
#2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
8 tasks
yipin-chen
approved these changes
Dec 28, 2024
prateek-kumar-improving
approved these changes
Dec 30, 2024
| assert.Nil(suite.T(), err) | ||
| assert.Equal(suite.T(), int64(1), res.Value()) | ||
|
|
||
| // TODO: run ZCard there |
There was a problem hiding this comment.
Why is this TO DO added here? This TO DO should be in the ZCARD test, right?
There was a problem hiding this comment.
I will merge this PR today. @prateek-kumar-improving, can you have a chat with Yury after he is back. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2833
Checklist
Before submitting the PR make sure the following are checked: