Add node test for checking exported symbols #2835
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,16 +14,16 @@ The release of Valkey GLIDE was tested on the following platforms: | |
|
|
||
| Linux: | ||
|
|
||
| - Ubuntu 22.04.1 (x86_64 and aarch64) | ||
| - Amazon Linux 2023 (AL2023) (x86_64) | ||
|
|
||
| macOS: | ||
|
|
||
| - macOS 14.7 (Apple silicon/aarch_64) | ||
|
|
||
| Alpine: | ||
|
|
||
| - node:alpine (default on aarch64 and x86_64) | ||
|
|
||
| ## NodeJS supported version | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,64 +11,70 @@ let globalObject = global as unknown; | |||||
|
|
||||||
| /* eslint-disable @typescript-eslint/no-require-imports */ | ||||||
| function loadNativeBinding() { | ||||||
| const scope = process.env.scope || "@scope"; | ||||||
|
There was a problem hiding this comment. move this to line 75 where it is used |
||||||
|
|
||||||
| let nativeBinding = []; | ||||||
|
There was a problem hiding this comment. can be removed if it is not used until line 76 |
||||||
| let nativeStr = process.env.native_binding; | ||||||
|
|
||||||
| if (nativeStr == undefined) { | ||||||
| switch (platform) { | ||||||
| case "linux": | ||||||
| switch (arch) { | ||||||
| case "x64": | ||||||
| switch (familySync()) { | ||||||
| case MUSL: | ||||||
| nativeStr = "linux-musl-x64"; | ||||||
| break; | ||||||
| case GLIBC: | ||||||
| default: | ||||||
| nativeStr = "linux-x64"; | ||||||
| break; | ||||||
| } | ||||||
|
|
||||||
| break; | ||||||
| case "arm64": | ||||||
| switch (familySync()) { | ||||||
| case MUSL: | ||||||
| nativeStr = "linux-musl-arm64"; | ||||||
| break; | ||||||
| case GLIBC: | ||||||
| default: | ||||||
| nativeStr = "linux-arm64"; | ||||||
| break; | ||||||
| } | ||||||
|
|
||||||
| break; | ||||||
| default: | ||||||
| throw new Error( | ||||||
| `Unsupported OS: ${platform}, architecture: ${arch}`, | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
| break; | ||||||
| case "darwin": | ||||||
| switch (arch) { | ||||||
| case "x64": | ||||||
| nativeStr = "darwin-x64"; | ||||||
| break; | ||||||
| case "arm64": | ||||||
| nativeStr = "darwin-arm64"; | ||||||
| break; | ||||||
| default: | ||||||
| throw new Error( | ||||||
| `Unsupported OS: ${platform}, architecture: ${arch}`, | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
| break; | ||||||
| default: | ||||||
| throw new Error( | ||||||
| `Unsupported OS: ${platform}, architecture: ${arch}`, | ||||||
| ); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| nativeBinding = require(`${scope}valkey-glide-${nativeStr}`); | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| if (!nativeBinding) { | ||||||
| throw new Error(`Failed to load native binding`); | ||||||
| } | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* eslint no-undef: off */ | ||
| module.exports = { | ||
| preset: "ts-jest", | ||
| transform: { | ||
| "^.+\\.(t|j)s$": ["ts-jest", { isolatedModules: true }], | ||
| }, | ||
| testEnvironment: "node", | ||
| testRegex: "/tests/.*\\.(test|spec)?\\.(ts|tsx)$", | ||
| moduleFileExtensions: [ | ||
| "ts", | ||
| "tsx", | ||
| "js", | ||
| "jsx", | ||
| "json", | ||
| "node", | ||
| "cjs", | ||
| "mjs", | ||
| ], | ||
| testTimeout: 600000, | ||
| reporters: [ | ||
| "default", | ||
| [ | ||
| "./node_modules/jest-html-reporter", | ||
| { | ||
| includeFailureMsg: true, | ||
| includeSuiteFailure: true, | ||
| executionTimeWarningThreshold: 60, | ||
| sort: "status", | ||
| }, | ||
| ], | ||
| ], | ||
| }; |
|
There was a problem hiding this comment. Can't you update There was a problem hiding this comment. package.json.tmpl has some changes to run this in local. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,75 @@ | ||||
| { | ||||
| "name": "${scope}${pkg_name}", | ||||
| "types": "build-ts/index.d.ts", | ||||
| "version": "${package_version}", | ||||
| "description": "General Language Independent Driver for the Enterprise (GLIDE) for Valkey", | ||||
| "main": "build-ts/index.js", | ||||
| "module": "build-ts/index.js", | ||||
| "type": "commonjs", | ||||
| "scripts": { | ||||
| "lint": "eslint .", | ||||
| "lint:fix": "eslint . --fix", | ||||
| "clean": "rm -rf build-ts/", | ||||
| "copy-declaration-files": "cp ../../build-ts/*.d.ts build-ts/ && cp ../../build-ts/src/*.d.ts build-ts/src/ && cp ../../build-ts/src/server-modules/*.d.ts build-ts/src/server-modules/", | ||||
| "build": "tsc && mkdir -p build-ts/src && mkdir -p build-ts/src/server-modules && npm run copy-declaration-files", | ||||
| "build:test": "npm i && npm run build", | ||||
| "test": "jest --verbose" | ||||
| }, | ||||
| "files": [ | ||||
| "/build-ts" | ||||
| ], | ||||
| "repository": { | ||||
| "type": "git", | ||||
| "url": "git+https://github.com/valkey-io/valkey-glide.git" | ||||
| }, | ||||
| "keywords": [ | ||||
| "valkey", | ||||
| "valkeyClient", | ||||
| "client", | ||||
| "valkey-glide" | ||||
| ], | ||||
| "author": "Valkey GLIDE Maintainers", | ||||
| "license": "Apache-2.0", | ||||
| "bugs": { | ||||
| "url": "https://github.com/valkey-io/valkey-glide/issues" | ||||
| }, | ||||
| "homepage": "https://github.com/valkey-io/valkey-glide#readme", | ||||
| "devDependencies": { | ||||
| "@jest/globals": "^29.7.0", | ||||
| "@types/jest": "^29.5.14", | ||||
| "ts-jest": "^29.2.5", | ||||
| "jest": "^29.7.0", | ||||
| "jest-html-reporter": "^3.10.2", | ||||
| "@types/node": "^18.11.18", | ||||
| "@typescript-eslint/eslint-plugin": "^5.48.0", | ||||
| "@typescript-eslint/parser": "^5.48.0", | ||||
| "eslint": "^8.31.0", | ||||
| "typescript": "^4.9.4", | ||||
| "${scope}valkey-glide-${nativeStr}": "../.." | ||||
| }, | ||||
| "optionalDependencies": { | ||||
| "${scope}valkey-glide-darwin-arm64": "${package_version}", | ||||
| "${scope}valkey-glide-darwin-x64": "${package_version}", | ||||
|
There was a problem hiding this comment.
Suggested change
This one is not supported now There was a problem hiding this comment. Will remove. Thanks. |
||||
| "${scope}valkey-glide-linux-arm64": "${package_version}", | ||||
| "${scope}valkey-glide-linux-x64": "${package_version}", | ||||
| "${scope}valkey-glide-linux-musl-arm64": "${package_version}", | ||||
| "${scope}valkey-glide-linux-musl-x64": "${package_version}" | ||||
| }, | ||||
| "eslintConfig": { | ||||
| "extends": [ | ||||
| "eslint:recommended", | ||||
| "plugin:@typescript-eslint/recommended" | ||||
| ], | ||||
| "parser": "@typescript-eslint/parser", | ||||
| "plugins": [ | ||||
| "@typescript-eslint" | ||||
| ], | ||||
| "ignorePatterns": [ | ||||
| "build-ts/*" | ||||
| ], | ||||
| "root": true | ||||
| }, | ||||
| "dependencies": { | ||||
| "detect-libc": "^2.0.3" | ||||
| } | ||||
| } | ||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it done by a linter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes