[backport main] remove native package references for MacOS x64 architecture #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
approved these changes
Dec 12, 2024
yipin-chen
approved these changes
Dec 12, 2024
|
CI is failing on DCO. |
prateek-kumar-improving
approved these changes
Dec 12, 2024
Signed-off-by: jbrinkman <[email protected]>
jbrinkman
force-pushed
the
node/jbrinkman-remove-darwin-x64
branch
from
1bed431 to
7b1b005
Compare
jbrinkman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request resolves issue (#2799).
This change removes the native package reference in package.json and updates the
npm/glideindex file to remove the native binding for the Darwin-x64 package which was removed in the Valkey-Glide 1.2.0 release.Checklist
Before submitting the PR make sure the following are checked: