Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Go language versions to include 1.20.0 #2740

Merged
merged 1 commit into from
Nov 22, 2024
+10 −10
Merged

Update supported Go language versions to include 1.20.0 #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/json_matrices/supported-languages-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
{
"language": "go",
"versions": ["1.22.0", "1.18.10"],
"always-run-versions": ["1.22.0", "1.18.10"]
"versions": ["1.22.0", "1.20.0"],
"always-run-versions": ["1.22.0", "1.20.0"]
}
]
8 changes: 4 additions & 4 deletions go/DEVELOPER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ Before starting this step, make sure you've installed all software requirements.
```bash
# For go1.22:
make install-dev-tools
# For go1.18:
make install-dev-tools-go1.18
# For go1.20:
make install-dev-tools-go1.20
```

### Test
Expand Down Expand Up @@ -201,8 +201,8 @@ Run from the main `/go` folder
```bash
# For go1.22:
make install-dev-tools
# For go1.18:
make install-dev-tools-go1.18
# For go1.22:
make install-dev-tools-go1.22

make lint
```
Expand Down
6 changes: 3 additions & 3 deletions go/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ install-build-tools:
go install google.golang.org/protobuf/cmd/[email protected]
cargo install cbindgen

install-dev-tools-go1.18:
install-dev-tools-go1.20:
go install github.com/vakenbolt/[email protected]
go install mvdan.cc/[email protected]
go install github.com/segmentio/[email protected]
go install honnef.co/go/tools/cmd/[email protected]

install-dev-tools-go1.18.10: install-dev-tools-go1.18
install-dev-tools-go1.20.0: install-dev-tools-go1.20

install-dev-tools-go1.22:
go install github.com/vakenbolt/[email protected]
Expand All @@ -20,7 +20,7 @@ install-dev-tools-go1.22.0: install-dev-tools-go1.22

install-dev-tools: install-dev-tools-go1.22.0

install-tools-go1.18.10: install-build-tools install-dev-tools-go1.18.10
install-tools-go1.20.0: install-build-tools install-dev-tools-go1.20.0

install-tools-go1.22.0: install-build-tools install-dev-tools-go1.22.0

Expand Down
2 changes: 1 addition & 1 deletion go/benchmarks/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/valkey-io/valkey-glide/go/glide/benchmarks

go 1.18
go 1.20

replace github.com/valkey-io/valkey-glide/go/glide => ../

Expand Down
Loading