Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add RESP2 support #2383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java: Add RESP2 support #2383

wants to merge 2 commits into from
+862 −544

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 2, 2024 •
edited
Loading

And update tests

Depends on #2381

Issue link

#2724

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Oct 2, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 2, 2024 19:19
jonathanl-bq
jonathanl-bq approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but otherwise looks good to me.

java/integTest/src/test/java/glide/cluster/ClusterTransactionTests.java Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 20, 2024
Open
2 tasks
yipin-chen
yipin-chen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Your CI is red.
Please rebase and re-run CI.

@Yury-Fridlyand
Java: RESP2
de92f3b 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
changelog
d220f6a 
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @jonathanl-bq @yipin-chen