New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: add ZMSCORE command #1357

Merged

acarbonetto merged 9 commits into valkey-io:main from Bit-Quill:python/integ_acongo_zmscore

May 1, 2024

Collaborator

aaron-congo commented Apr 26, 2024 •

edited

Loading

Issue #, if available:
N/A

Description of changes:

https://redis.io/docs/latest/commands/zmscore/
Note: includes value conversion
- RESP2 returns an array of BulkString values, where each string represents a Double. The value conversion added in this PR converts array-of-bulkstring responses to array-of-double responses, which matches the RESP3 format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aaron-congo requested a review from a team as a code owner

April 26, 2024 22:43

aaron-congo added the python label

shohamazon reviewed

View reviewed changes

glide-core/src/client/value_conversion.rs Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

shohamazon reviewed

View reviewed changes

python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved

Yury-Fridlyand requested review from GumpacG, jonathanl-bq, Yury-Fridlyand and acarbonetto

April 30, 2024 17:47

Yury-Fridlyand approved these changes

View reviewed changes

aaron-congo and others added 6 commits

April 30, 2024 14:01


          Python: add ZMSCORE command (#250)

73acee1


          Update CHANGELOG with PR link

82dd3a0


          PR suggestions

8c9ff35


          Create convert_array_elements function

72cb7df


          Fix rust formatting

c9032a0


          PR suggestions

0755bdf

aaron-congo force-pushed the python/integ_acongo_zmscore branch from eb86013 to 0755bdf Compare

April 30, 2024 21:01

shohamazon approved these changes

View reviewed changes

glide-core/src/client/value_conversion.rs Outdated Show resolved Hide resolved

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved

python/python/glide/async_commands/transaction.py Show resolved Hide resolved

aaron-congo and others added 3 commits

May 1, 2024 08:37


          PR suggestions

bc6c4be


          Fix rust formatting

bb4b442


          Merge branch 'main' into python/integ_acongo_zmscore

da88603

acarbonetto merged commit 47364d3 into valkey-io:main

45 checks passed

acarbonetto deleted the python/integ_acongo_zmscore branch

May 1, 2024 16:34

aaron-congo mentioned this pull request

Python: add ZRANGESTORE command Bit-Quill/valkey-glide#258

Merged

tjzhang-BQ pushed a commit to Bit-Quill/valkey-glide that referenced this pull request


          Python: add ZMSCORE command (valkey-io#1357)

43143d6

* Python: add ZMSCORE command (#250)

* Update CHANGELOG with PR link

* PR suggestions

* Create convert_array_elements function

* Fix rust formatting

* PR suggestions

* PR suggestions

* Fix rust formatting

---------

Co-authored-by: Andrew Carbonetto <[email protected]>

cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request


          Python: add ZMSCORE command (valkey-io#1357)

6d19ff6

* Python: add ZMSCORE command (#250)

* Update CHANGELOG with PR link

* PR suggestions

* Create convert_array_elements function

* Fix rust formatting

* PR suggestions

* PR suggestions

* Fix rust formatting

---------

Co-authored-by: Andrew Carbonetto <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shohamazon shohamazon approved these changes

Yury-Fridlyand Yury-Fridlyand approved these changes

GumpacG Awaiting requested review from GumpacG

jonathanl-bq Awaiting requested review from jonathanl-bq

acarbonetto Awaiting requested review from acarbonetto

Labels

python