Java: Add Zdiffstore command. (Sorted Set Group)
#1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elen-Ghulam
requested review from
alex-arzola-imp,
barshaul,
Yury-Fridlyand,
acarbonetto,
shohamazon and
jonathanl-bq
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
acarbonetto
changed the title
Zdiffstore command. (Sorted Set Group)
Yury-Fridlyand
approved these changes
Apr 9, 2024
SanHalacogluImproving
force-pushed
the
java/integ_SanH_add_Zdiffstore
branch
from
3cb737b to
9bfcf12
Compare
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/test/java/glide/api/models/TransactionTests.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
Apr 11, 2024
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
| * assert payload > 0; // At least one member differed in "key1" compared to "key2", and this difference was stored in "mySortedSet". | ||
| * }</pre> | ||
| */ | ||
| CompletableFuture<Long> zdiffstore(String destination, String[] keys); |
There was a problem hiding this comment.
Does it make sense to swap keys and destination? I think it's easier to understand. Redis uses this ordering because they have a varargs on the keys, but we don't need to restrict ourselves.
There was a problem hiding this comment.
Don't think so. We have stuck to the Redis ordering up to this point. Does not make sense to change it now.
acarbonetto
force-pushed
the
java/integ_SanH_add_Zdiffstore
branch
from
0aaa283 to
c34e66c
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Apr 11, 2024
Elen-Ghulam
approved these changes
Apr 11, 2024
alex-arzola-imp
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Apr 12, 2024
* Java: Add Zdiffstore command. (Sorted Set Group) (#185) * Minor documentation + minor IT test update. * Changelog revert. * Rebase + Spotless * Minor documentation update + minor TransactionTests update + revert CHANGELOG.md * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add Zdiffstore command. (Sorted Set Group) (#185) * Minor documentation + minor IT test update. * Changelog revert. * Rebase + Spotless * Minor documentation update + minor TransactionTests update + revert CHANGELOG.md * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.