Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add examples to missing commands and minor fixes Generic Commands. (#125) #1070

Conversation

SanHalacogluImproving
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SanHalacogluImproving SanHalacogluImproving requested a review from a team as a code owner March 4, 2024 19:23
* @param args Arguments for the custom command including the command name
* @param route Routing configuration for the command
* @return Response from Redis containing an <code>Object</code>.
* @example
* <pre>
* ClusterValue&lt;Object&gt; result = clusterClient.customCommand(new String[]{ "CONFIG", "GET", "maxmemory"}, ALL_NODES).get();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the &lt / &gt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a typo, but there is a workaround to avoid that
javadoc follows HTML formatting rules

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acarbonetto acarbonetto added the java issues and fixes related to the java client label Mar 5, 2024
@acarbonetto acarbonetto merged commit 5c46015 into valkey-io:main Mar 5, 2024
11 checks passed
@acarbonetto acarbonetto deleted the java/integ_SanH_addExamplesForGenericCommands branch March 5, 2024 20:19
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
…ds. (#125) (valkey-io#1070)

* Java: Add examples to missing commands and minor fixes. (#125)

* Minor documentation changes.

* Minor documentation changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants