Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which versions of npm are workable. #1063

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

nihohit
Copy link
Contributor

@nihohit nihohit commented Mar 4, 2024

Issue #, if available:
#1059

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nihohit nihohit requested a review from a team as a code owner March 4, 2024 07:04
@@ -15,7 +15,7 @@ Software Dependencies
> Note: Currently, we only support npm major version 8. f you have a later version installed, you can downgrade it with `npm i -g npm@8`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete it too?

@shachlanAmazon shachlanAmazon merged commit 93e4703 into valkey-io:main Mar 4, 2024
6 checks passed
@nihohit nihohit deleted the npm branch March 4, 2024 11:44
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants