Java: Add LRange and LTrim commands. (List Commands) #1041

SanHalacogluImproving · 2024-02-26T22:52:13Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

acarbonetto · 2024-02-27T00:05:32Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

-     * @param elements The elements to insert at the tail of the list stored at <code>key</code>.
-     * @return Command Response - The length of the list after the push operations.
-     */
-    public T rpush(@NonNull String key, @NonNull String[] elements) {


Is this just diff issue? Or did you move these?

Please move new functions to the end to avoid this

I am roughly following the order that they had in the Node client and Py. (they differ from each other a bit). This was just a rebase mistake at some point so i just moved it to the correct spot.

Since git fails to detect that you added few functions in the middle, you have to reorder them. The actual order does not matter, I added all commends to the end to simplify reviewing.

java/integTest/src/test/java/glide/TransactionTestUtilities.java

java/client/src/main/java/glide/api/BaseClient.java

java/client/src/main/java/glide/api/commands/ListBaseCommands.java

Yury-Fridlyand · 2024-02-27T00:38:13Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

-     * @param elements The elements to insert at the tail of the list stored at <code>key</code>.
-     * @return Command Response - The length of the list after the push operations.
-     */
-    public T rpush(@NonNull String key, @NonNull String[] elements) {


Please move new functions to the end to avoid this

java/client/src/main/java/glide/api/models/BaseTransaction.java

java/client/src/test/java/glide/api/RedisClientTest.java

java/client/src/test/java/glide/api/models/TransactionTests.java

java/integTest/src/test/java/glide/TransactionTestUtilities.java

java/client/src/main/java/glide/api/commands/ListBaseCommands.java

shohamazon · 2024-03-03T16:02:08Z

java/client/src/main/java/glide/api/commands/ListBaseCommands.java

+
+    /**
+     * Trims an existing list so that it will contain only the specified range of elements specified.
+     * <br>


here
is in a new line, but in lrange it's not, let's be consistent

This is caused by Spotless hence why it looks like that.

shohamazon · 2024-03-03T16:06:40Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

@@ -572,6 +523,109 @@ public T lpopCount(@NonNull String key, long count) {
        return getThis();
    }

+    /**


same comments

shohamazon · 2024-03-03T16:07:07Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

-     * @param elements The elements to insert at the tail of the list stored at <code>key</code>.
-     * @return Command Response - The length of the list after the push operations.
-     */
-    public T rpush(@NonNull String key, @NonNull String[] elements) {


Yury-Fridlyand · 2024-03-04T19:08:58Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

+     *
+     * @see <a href="https://redis.io/commands/rpop/">redis.io</a> for details.
+     * @param count The count of the elements to pop from the list.
+     * @returns Command Response - An array of popped elements will be returned depending on the


Suggested change

* @returns Command Response - An array of popped elements will be returned depending on the

* @return Command Response - An array of popped elements will be returned depending on the

Yury-Fridlyand · 2024-03-04T19:09:08Z

java/client/src/main/java/glide/api/commands/ListBaseCommands.java

+     * @param key The key of the list.
+     * @param start The starting point of the range.
+     * @param end The end of the range.
+     * @return Always <code>OK</code>. <br>


Suggested change

* @return Always <code>OK</code>. <br>

* @return Always <code>OK</code>.<br>

Yury-Fridlyand · 2024-03-04T19:09:52Z

java/client/src/main/java/glide/api/models/BaseTransaction.java

+        return getThis();
+    }
+
+    /**


Please reorder to simplify the diff

SanHalacogluImproving requested a review from a team as a code owner February 26, 2024 22:52

SanHalacogluImproving changed the title ~~Java: Add LRange command. (List Commands)~~ Java: Add LRange and LTrim commands. (List Commands) Feb 26, 2024

acarbonetto requested review from barshaul, shachlanAmazon and shohamazon February 27, 2024 00:02

acarbonetto added the java issues and fixes related to the java client label Feb 27, 2024

acarbonetto assigned SanHalacogluImproving Feb 27, 2024

acarbonetto approved these changes Feb 27, 2024

View reviewed changes

Yury-Fridlyand approved these changes Feb 27, 2024

View reviewed changes

Yury-Fridlyand reviewed Feb 27, 2024

View reviewed changes

java/integTest/src/test/java/glide/TransactionTestUtilities.java Show resolved Hide resolved

Yury-Fridlyand approved these changes Feb 29, 2024

View reviewed changes

shohamazon approved these changes Mar 3, 2024

View reviewed changes

SanHalacogluImproving added 7 commits March 4, 2024 10:50

Java: Add LRange command. (List Commands)

b38b6b0

Java: Add LTrim command. (List Commands)

9b791ae

Added examples.

db6d044

Star import fix.

e767677

Minor changes based on PR comments.

7797551

Minor documentation change.

827ca0d

Rebase and spotless.

88b44ee

SanHalacogluImproving force-pushed the java/integ_SanH_add_Lrange branch from e62eac7 to 88b44ee Compare March 4, 2024 18:53

Yury-Fridlyand reviewed Mar 4, 2024

View reviewed changes

SanHalacogluImproving added 2 commits March 4, 2024 11:12

Minor documentation fixes.

d2c61b1

Spotless.

b6edfd1

Yury-Fridlyand approved these changes Mar 4, 2024

View reviewed changes

Yury-Fridlyand merged commit 5f687a3 into valkey-io:main Mar 4, 2024
11 checks passed

Yury-Fridlyand deleted the java/integ_SanH_add_Lrange branch March 4, 2024 19:31

cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024

Java: Add LRange and LTrim commands. (List Commands) (valkey-io#1041)

f2c0b4f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java: Add LRange and LTrim commands. (List Commands) #1041

Java: Add LRange and LTrim commands. (List Commands) #1041

SanHalacogluImproving commented Feb 26, 2024

acarbonetto Feb 27, 2024

Yury-Fridlyand Feb 27, 2024

SanHalacogluImproving Feb 27, 2024

Yury-Fridlyand Feb 27, 2024

shohamazon Mar 3, 2024

Yury-Fridlyand Feb 27, 2024

shohamazon Mar 3, 2024

SanHalacogluImproving Mar 4, 2024

shohamazon Mar 3, 2024

shohamazon Mar 3, 2024

Yury-Fridlyand Mar 4, 2024

Yury-Fridlyand Mar 4, 2024

Yury-Fridlyand Mar 4, 2024

	* @returns Command Response - An array of popped elements will be returned depending on the
	* @return Command Response - An array of popped elements will be returned depending on the

	* @return Always <code>OK</code>. <br>
	* @return Always <code>OK</code>.<br>

Java: Add LRange and LTrim commands. (List Commands) #1041

Java: Add LRange and LTrim commands. (List Commands) #1041

Conversation

SanHalacogluImproving commented Feb 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment