Add CONFIG REWRITE and CONFIG RESETSTAT.
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
approved these changes
Feb 21, 2024
| @@ -130,6 +132,10 @@ public void transaction_builds_protobuf_request(BaseTransaction<?> transaction) | |||
| transaction.scard("key"); | |||
| results.add(Pair.of(SCard, ArgsArray.newBuilder().addArgs("key").build())); | |||
|
|
|||
| transaction.configRewrite().configResetStat(); | |||
| public class TestUtilities { | ||
| /** Extract integer parameter value from INFO command output */ | ||
| public static int getValueFromInfo(String data, String value) { | ||
| for (var line : data.split("\r\n")) { |
There was a problem hiding this comment.
nit: suggestion:
Optional<String>
line = Arrays.stream(data.split("\r\n")).filter(l -> l.contains(value)).findFirst();
if (line.isEmpty()) {
fail();
}
return Integer.parseInt(line.get().split(":")[1]);
There was a problem hiding this comment.
There are blank lines between sections
| return baseTransaction; | ||
| } | ||
|
|
||
| public static Object[] transactionTestResult() { | ||
| return new Object[] { | ||
| "OK", | ||
| OK, |
acarbonetto
reviewed
Feb 21, 2024
java/client/src/main/java/glide/api/commands/ServerManagementClusterCommands.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ServerManagementClusterCommands.java
Show resolved
Hide resolved
SanHalacogluImproving
force-pushed
the
java/integ_yuryf_config_rewrite_reset
branch
from
d1836dc to
e6d7e25
Compare
acarbonetto
requested review from
barshaul,
shachlanAmazon,
shohamazon and
ikolomi
shachlanAmazon
approved these changes
Mar 4, 2024
| * | ||
| * @see <a href="https://redis.io/commands/config-rewrite/">redis.io</a> for details. | ||
| * @return <code>OK</code> when the configuration was rewritten properly, otherwise an error is | ||
| * raised. |
There was a problem hiding this comment.
raised -> thrown
throughout
| * @return <code>OK</code> when the configuration was rewritten properly, otherwise an error is | ||
| * raised. | ||
| * @example | ||
| * <pre> |
There was a problem hiding this comment.
throughout - should there be empty spaces before the <pre>?
There was a problem hiding this comment.
Tricks of java linter (spotless)
| * Rewrite the configuration file with the current configuration. | ||
| * | ||
| * @see <a href="https://redis.io/commands/config-rewrite/">redis.io</a> for details. | ||
| * @return <code>OK</code> when the configuration was rewritten properly, otherwise an error is |
There was a problem hiding this comment.
no error will be raised. please check the documentation - sometimes there's a difference between the client docs and transaction docs.
|
|
||
| @Test | ||
| @SneakyThrows | ||
| public void config_reset_stat() { |
There was a problem hiding this comment.
missing the config rewrite tests.
There was a problem hiding this comment.
no IT for
CONFIG REWRITE, because redis in IT runs without config file
The command fails
There was a problem hiding this comment.
have you seen how the other wrappers implemented these tests?
|
Please, resolve conflicts |
* Add `CONFIG REWRITE` and `CONFIG RESETSTAT`. Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
SanHalacogluImproving
force-pushed
the
java/integ_yuryf_config_rewrite_reset
branch
from
e094f5f to
23d176a
Compare
Yury-Fridlyand
commented
Mar 5, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
commented
Mar 6, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `CONFIG REWRITE` and `CONFIG RESETSTAT`. (#95) --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
CONFIG REWRITEhttps://redis.io/commands/config-rewrite/CONFIG RESETSTAThttps://redis.io/commands/config-resetstat/CONFIG REWRITE, because redis in IT runs without config file