Lint all TS files base on our prettier for easier developer life, and added CI prettier step #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
requested review from
barshaul,
asafpamzn,
shachlanAmazon,
shohamazon and
adanWattad
avifenesh
force-pushed
the
Linting/TS
branch
2 times, most recently
from
2e259b5 to
3a9d61b
Compare
avifenesh
changed the title
Yury-Fridlyand
approved these changes
Feb 20, 2024
avifenesh
force-pushed
the
Linting/TS
branch
3 times, most recently
from
dfe2ea3 to
14a70d8
Compare
avifenesh
force-pushed
the
Linting/TS
branch
from
14a70d8 to
8d8e9e4
Compare
avifenesh
force-pushed
the
Linting/TS
branch
11 times, most recently
from
9e2878a to
25b310b
Compare
avifenesh
force-pushed
the
Linting/TS
branch
6 times, most recently
from
a83e66f to
1a97371
Compare
shachlanAmazon
approved these changes
Mar 6, 2024
nope |
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
… added CI prettier step (valkey-io#1002) * Edited all files to fit prettier standart and added prettier command to pckage.json's * Edited lint-ts to check for ts folders and to run globally * adding time to after all for avoiding failure on timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we recommend in our DEVELOPER.md for Node to use prettier, we should follow the lint of what prettier give as a default.
As Node developers, we encountered a lot the borden of fixing unwanted lints from prettier, that are actually needed lints, but are not part of the PR context, and for saving our time and nerves I created new workspace with fresh prettier and let it fix the TS files so we don't need to fight with it anymore - all what developers need to do is to use the default of prettier.
Added prettier scripts for check and format, added instructions for usage, added to the CI, and aligned all the file with the standard.
Changed npm-cd workflow to fit the changes - #1081
Changed lint-ts to instead of receptively create a task for each folder and ending running lint on the whole repo, to loop on the ts folders. end lint them specifically
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.