Skip to content

Commit

Permalink
Reverted changes in python.yml
Browse files Browse the repository at this point in the history
mypy: disable_error_code="arg-type"

Signed-off-by: Eran Ifrah <[email protected]>
  • Loading branch information
eifrah-aws committed Oct 14, 2024
1 parent 09153ce commit a7b3923
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ jobs:
- name: Install dependencies
working-directory: ./python
run: |
sudo apt install -y mypy-protobuf
python -m pip install --upgrade pip
pip install mypy-protobuf
- name: Build Python wrapper
uses: ./.github/workflows/build-python-wrapper
Expand All @@ -121,6 +122,7 @@ jobs:
- name: Test with pytest
working-directory: ./python
run: |
source .env/bin/activate
cd python/tests/
pytest --asyncio-mode=auto --html=pytest_report.html --self-contained-html
Expand Down Expand Up @@ -186,6 +188,7 @@ jobs:
- name: Test pubsub with pytest
working-directory: ./python
run: |
source .env/bin/activate
cd python/tests/
pytest --asyncio-mode=auto -k test_pubsub --html=pytest_report.html --self-contained-html
Expand Down Expand Up @@ -215,7 +218,8 @@ jobs:
if: always()
working-directory: ./python
run: |
sudo apt install -y flake8 isort black
python -m pip install --upgrade pip
pip install flake8 isort black
- name: Lint python with isort
if: always()
Expand Down Expand Up @@ -273,6 +277,7 @@ jobs:
- name: Test compatibility with pytest
working-directory: ./python
run: |
source .env/bin/activate
pytest --asyncio-mode=auto -m smoke_test --html=pytest_report.html --self-contained-html
- name: Upload test reports
Expand Down Expand Up @@ -344,6 +349,7 @@ jobs:
- name: Test with pytest
working-directory: ./python
run: |
source .env/bin/activate
cd python/tests/
pytest --asyncio-mode=auto --tls --cluster-endpoints=${{ secrets.MEMDB_MODULES_ENDPOINT }} -k server_modules --html=pytest_report.html --self-contained-html
Expand All @@ -354,4 +360,4 @@ jobs:
with:
name: modules-test-report-${{ matrix.host.TARGET }}-python-${{ matrix.python }}-server-${{ matrix.engine.version }}
path: |
python/python/tests/pytest_report.html
python/python/tests/pytest_report.html
1 change: 1 addition & 0 deletions python/python/tests/test_async_client.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
# mypy: disable_error_code="arg-type"

from __future__ import annotations

Expand Down

0 comments on commit a7b3923

Please sign in to comment.