Merge fixups

Signed-off-by: ikolomi <[email protected]>

benchmarks/rust/src/main.rs

@@ -1,7 +1,6 @@
 /**
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #[cfg(not(target_env = "msvc"))]
 use tikv_jemallocator::Jemalloc;
 

glide-core/build.rs

@@ -1,7 +1,6 @@
 /**
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #[cfg(feature = "socket-layer")]
 fn build_protobuf() {
     let customization_options = protobuf_codegen::Customize::default()

glide-core/redis-rs/redis/src/cluster.rs

@@ -105,7 +105,7 @@ impl<'a> Input<'a> {
     }
 }
 
-impl<'a> Routable for Input<'a> {
+impl Routable for Input<'_> {
     fn arg_idx(&self, idx: usize) -> Option<&[u8]> {
         match self {
             Input::Slice { cmd: _, routable } => routable.arg_idx(idx),

glide-core/redis-rs/redis/src/cluster_routing.rs

@@ -1378,7 +1378,7 @@ impl ShardAddrs {
     }
 }
 
-impl<'a> IntoIterator for &'a ShardAddrs {
+impl IntoIterator for &ShardAddrs {
     type Item = Arc<String>;
     type IntoIter = std::iter::Chain<Once<Arc<String>>, std::vec::IntoIter<Arc<String>>>;
 

glide-core/redis-rs/redis/src/cmd.rs

@@ -40,7 +40,7 @@ pub struct Iter<'a, T: FromRedisValue> {
     cmd: Cmd,
 }
 
-impl<'a, T: FromRedisValue> Iterator for Iter<'a, T> {
+impl<T: FromRedisValue> Iterator for Iter<'_, T> {
     type Item = T;
 
     #[inline]

glide-core/redis-rs/redis/src/commands/cluster_scan.rs

@@ -24,7 +24,6 @@ use strum_macros::Display;
 /// The [[`ScanState`]] struct represents the state of a scan operation in a Redis cluster.
 /// It holds information about the current scan state, including the cursor position, scanned slots map,
 /// address being scanned, and address's epoch.
-
 const BITS_PER_U64: usize = u64::BITS as usize;
 const NUM_OF_SLOTS: usize = SLOT_SIZE as usize;
 const BITS_ARRAY_SIZE: usize = NUM_OF_SLOTS / BITS_PER_U64;

glide-core/redis-rs/redis/src/connection.rs

@@ -287,7 +287,7 @@ impl IntoConnectionInfo for ConnectionInfo {
 /// - Specifying DB: `redis://127.0.0.1:6379/0`
 /// - Enabling TLS: `rediss://127.0.0.1:6379`
 /// - Enabling Insecure TLS: `rediss://127.0.0.1:6379/#insecure`
-impl<'a> IntoConnectionInfo for &'a str {
+impl IntoConnectionInfo for &str {
     fn into_connection_info(self) -> RedisResult<ConnectionInfo> {
         match parse_redis_url(self) {
             Some(u) => u.into_connection_info(),
@@ -1578,7 +1578,7 @@ impl<'a> PubSub<'a> {
     }
 }
 
-impl<'a> Drop for PubSub<'a> {
+impl Drop for PubSub<'_> {
     fn drop(&mut self) {
         let _ = self.con.exit_pubsub();
     }

glide-core/redis-rs/redis/src/types.rs

@@ -1443,7 +1443,7 @@ impl ToRedisArgs for String {
     }
 }
 
-impl<'a> ToRedisArgs for &'a str {
+impl ToRedisArgs for &str {
     fn write_redis_args<W>(&self, out: &mut W)
     where
         W: ?Sized + RedisWrite,
@@ -1465,7 +1465,7 @@ impl<T: ToRedisArgs> ToRedisArgs for Vec<T> {
     }
 }
 
-impl<'a, T: ToRedisArgs> ToRedisArgs for &'a [T] {
+impl<T: ToRedisArgs> ToRedisArgs for &[T] {
     fn write_redis_args<W>(&self, out: &mut W)
     where
         W: ?Sized + RedisWrite,

glide-core/src/client/types.rs

@@ -1,7 +1,6 @@
 /*
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #[allow(unused_imports)]
 use logger_core::log_warn;
 #[allow(unused_imports)]

glide-core/src/errors.rs

@@ -1,7 +1,6 @@
 /*
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 use redis::RedisError;
 
 #[repr(C)]

glide-core/src/lib.rs

@@ -1,7 +1,6 @@
 /*
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #[cfg(feature = "socket-layer")]
 include!(concat!(env!("OUT_DIR"), "/protobuf/mod.rs"));
 pub mod client;

glide-core/tests/test_socket_listener.rs

@@ -1,7 +1,6 @@
 /*
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #![cfg(feature = "socket-layer")]
 use glide_core::*;
 use rsevents::{Awaitable, EventState, ManualResetEvent};

glide-core/tests/utilities/mod.rs

@@ -1,7 +1,6 @@
 /*
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
-
 #![allow(dead_code)]
 use futures::Future;
 use glide_core::{

go/src/lib.rs

@@ -1,7 +1,6 @@
 /*
 * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 */
-
 #![deny(unsafe_op_in_unsafe_fn)]
 use glide_core::client::Client as GlideClient;
 use glide_core::connection_request;
@@ -79,23 +78,6 @@ impl Default for CommandResponse {
     }
 }
 
-impl Default for CommandResponse {
-    fn default() -> Self {
-        CommandResponse {
-            response_type: ResponseType::default(),
-            int_value: 0,
-            float_value: 0.0,
-            bool_value: false,
-            string_value: ptr::null_mut(),
-            string_value_len: 0,
-            array_value: ptr::null_mut(),
-            array_value_len: 0,
-            map_key: ptr::null_mut(),
-            map_value: ptr::null_mut(),
-        }
-    }
-}
-
 #[repr(C)]
 #[derive(Debug, Default)]
 pub enum ResponseType {

node/rust-client/src/lib.rs

@@ -1,8 +1,8 @@
-use glide_core::Telemetry;
-use redis::GlideConnectionOptions;
 /**
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
+use glide_core::Telemetry;
+use redis::GlideConnectionOptions;
 
 #[cfg(not(target_env = "msvc"))]
 use tikv_jemallocator::Jemalloc;

node/tests/GlideClusterClient.test.ts

@@ -406,20 +406,6 @@ describe("GlideClusterClient", () => {
             const client = await GlideClusterClient.createClient(
                 getClientConfigurationOption(cluster.getAddresses(), protocol),
             );
-            const lmpopArr = [];
-
-            if (!cluster.checkIfServerVersionLessThan("7.0.0")) {
-                lmpopArr.push(
-                    client.lmpop(["abc", "def"], ListDirection.LEFT, {
-                        count: 1,
-                    }),
-                );
-                lmpopArr.push(
-                    client.blmpop(["abc", "def"], ListDirection.RIGHT, 0.1, {
-                        count: 1,
-                    }),
-                );
-            }
 
             const promises: Promise<unknown>[] = [
                 client.blpop(["abc", "zxy", "lkn"], 0.1),

python/src/lib.rs

@@ -1,8 +1,8 @@
-use bytes::Bytes;
-use glide_core::client::FINISHED_SCAN_CURSOR;
 /**
  * Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
  */
+use bytes::Bytes;
+use glide_core::client::FINISHED_SCAN_CURSOR;
 use glide_core::start_socket_listener;
 use glide_core::Telemetry;
 use glide_core::MAX_REQUEST_ARGS_LENGTH;