Minor Makefile cleanup #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We can specify SHELL = /bin/sh to avoid having to do `$(shell sh -c '<cmd>')` and instead just doing `$(shell <cmd)`. * Use makefile built-in `word` to parse library version info. * Minor cleanup of OS specific conditional blocks. * Remove dead `CXX` assignment (it was required for the qt example). * re-enable `-pedantic` for FreeBSD Signed-off-by: michael-grunder <[email protected]>
michael-grunder
force-pushed
the
makefile-cleanup
branch
from
4302eb2 to
f88d5f1
Compare
bjosv
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
LGTM!
If we keep SunOS support its might be good that we look into a CI for it (for a rainy day).
Maybe https://github.com/vmactions/solaris-vm can be used.
Good idea. I know people use Hiredis in some exotic environments (like AIX). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(shell sh -c '<cmd>')and instead just doing$(shell <cmd).wordto parse library version info.CXXassignment (it was required for the qt example).-pedanticfor FreeBSD