Feature/114 comparing two properties

.editorconfig

@@ -0,0 +1,39 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = crlf
+indent_style = space
+
+[*.cs]
+indent_size = 4
+insert_final_newline = true
+trim_trailing_whitespace = true
+dotnet_sort_system_directives_first = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch= true
+csharp_new_line_before_finally= true
+csharp_new_line_before_members_in_object_initializers= true
+csharp_new_line_before_members_in_anonymous_types= true
+csharp_new_line_between_query_expression_clauses= true
+csharp_indent_case_contents= true
+csharp_indent_switch_labels= true
+csharp_indent_labels = no_change
+csharp_space_after_cast = false
+csharp_space_after_keywords_in_control_flow_statements= true
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_preserve_single_line_statements= true
+csharp_preserve_single_line_blocks= true
+
+[*.sln]
+indent_style = tab
+
+[*.{csproj, yml, config, cake}]
+indent_style = space
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false

.gitattributes

@@ -0,0 +1,5 @@
+* text=auto
+
+*.cs text diff=csharp eol=crlf
+*.sln text merge=union eol=crlf
+*.csproj text merge=union eol=crlf

.gitignore

@@ -297,8 +297,8 @@ __pycache__/
 *.pyc
 
 # Cake - Uncomment if you are using it
- tools/**
- !tools/packages.config
+tools/**
+!tools/packages.config
 
 # Tabs Studio
 *.tss
@@ -312,5 +312,5 @@ __pycache__/
 *.odx.cs
 *.xsd.cs
 
-# diff 
-*.orig 
+# diff
+*.orig

.vscode/launch.json

@@ -1,52 +1,52 @@
 {
-	"version": "0.2.0",
-	"configurations": [
-		{
-			"name": ".NET Core Launch (console)",
-			"type": "coreclr",
-			"request": "launch",
-			"preLaunchTask": "build",
-			"program": "${workspaceRoot}/tests/Valit.Tests/bin/Debug/netcoreapp2.0/Valit.Tests.dll",
-			"args": [],
-			"cwd": "${workspaceRoot}",
-			"stopAtEntry": false,
-			"console": "internalConsole"
-		},
-		{
-			"name": ".NET Core Launch (web)",
-			"type": "coreclr",
-			"request": "launch",
-			"preLaunchTask": "build",
-			"program": "${workspaceRoot}/tests/Valit.Tests/bin/Debug/netcoreapp2.0/Valit.Tests.dll",
-			"args": [],
-			"cwd": "${workspaceRoot}",
-			"stopAtEntry": false,
-			"launchBrowser": {
-				"enabled": true,
-				"args": "${auto-detect-url}",
-				"windows": {
-					"command": "cmd.exe",
-					"args": "/C start ${auto-detect-url}"
-				},
-				"osx": {
-					"command": "open"
-				},
-				"linux": {
-					"command": "xdg-open"
-				}
-			},
-			"env": {
-				"ASPNETCORE_ENVIRONMENT": "Development"
-			},
-			"sourceFileMap": {
-				"/Views": "${workspaceRoot}/Views"
-			}
-		},
-		{
-			"name": ".NET Core Attach",
-			"type": "coreclr",
-			"request": "attach",
-			"processId": "${command:pickProcess}"
-		}
-	]
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "name": ".NET Core Launch (console)",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build",
+      "program": "${workspaceRoot}/tests/Valit.Tests/bin/Debug/netcoreapp2.0/Valit.Tests.dll",
+      "args": [],
+      "cwd": "${workspaceRoot}",
+      "stopAtEntry": false,
+      "console": "internalConsole"
+    },
+    {
+      "name": ".NET Core Launch (web)",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build",
+      "program": "${workspaceRoot}/tests/Valit.Tests/bin/Debug/netcoreapp2.0/Valit.Tests.dll",
+      "args": [],
+      "cwd": "${workspaceRoot}",
+      "stopAtEntry": false,
+      "launchBrowser": {
+        "enabled": true,
+        "args": "${auto-detect-url}",
+        "windows": {
+          "command": "cmd.exe",
+          "args": "/C start ${auto-detect-url}"
+        },
+        "osx": {
+          "command": "open"
+        },
+        "linux": {
+          "command": "xdg-open"
+        }
+      },
+      "env": {
+        "ASPNETCORE_ENVIRONMENT": "Development"
+      },
+      "sourceFileMap": {
+        "/Views": "${workspaceRoot}/Views"
+      }
+    },
+    {
+      "name": ".NET Core Attach",
+      "type": "coreclr",
+      "request": "attach",
+      "processId": "${command:pickProcess}"
+    }
+  ]
 }

.vscode/tasks.json

@@ -1,17 +1,17 @@
 {
-	// See https://go.microsoft.com/fwlink/?LinkId=733558
-	// for the documentation about the tasks.json format
-	"version": "2.0.0",
-	"tasks": [
-		{
-			"taskName": "build",
-			"command": "dotnet build",
-			"type": "shell",
-			"group": "build",
-			"presentation": {
-				"reveal": "silent"
-			},
-			"problemMatcher": "$msCompile"
-		}
-	]
+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format
+  "version": "2.0.0",
+  "tasks": [
+    {
+      "taskName": "build",
+      "command": "dotnet build",
+      "type": "shell",
+      "group": "build",
+      "presentation": {
+        "reveal": "silent"
+      },
+      "problemMatcher": "$msCompile"
+    }
+  ]
 }

CONTRIBUTING.md

@@ -49,6 +49,11 @@ When you're done make sure all tests passess. Navigate to the ```Valit.Tests```
 dotnet test
 ```
 
+You can also run the following command for continuous testing:
+```
+dotnet watch test // this will compile the project and rerun the tests on every file change
+```
+
 Alternatively, you can use our **Cake script** which is placed in the root folder. Navigate there and run:
 ```
 ./build.sh //on Unix
@@ -63,7 +68,7 @@ When the code is stable, you can submit your changes by creating a pull request.
 git push origin <name_of_your_branch>
 ```
 
-Then go to the **GitHub -> Pull Request -> New Pull Request**. 
+Then go to the **GitHub -> Pull Request -> New Pull Request**.
 Select **develop** as base and your branch as compare. We provide default template for PR description:
 
 ![PR_Template](http://foreverframe.net/wp-content/uploads/2017/09/Screen-Shot-2017-09-27-at-21.16.02.png)
@@ -86,7 +91,7 @@ Each PR must fulfill certain conditions before it can be merged:
 
 If some of the above won't be fulfilled (due to change request or some mistake) simply fix it locally on your machine, create new commit and push it to origin. This will update the exisitng PR and will kick off all checks again.
 
-If everything will be fine, your changes will be merged into develop, branch will be deleted and related issue will be closed. 
+If everything will be fine, your changes will be merged into develop, branch will be deleted and related issue will be closed.
 
 # WELL DONE AND THANK YOU VERY MUCH!
 

Valit.sln

@@ -1,4 +1,4 @@
-
+
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
 VisualStudioVersion = 15.0.26730.16

build.cake

@@ -4,38 +4,38 @@ var target = Argument("target", "Default");
 var configuration = Argument("configuration", "Release");
 
 Task("dotnet-restore")
-	.Does(() => 
-	{
-		DotNetCoreRestore("./Valit.sln");
-	});
+        .Does(() => 
+        {
+                DotNetCoreRestore("./Valit.sln");
+        });
 
 Task("dotnet-build")
-	.IsDependentOn("dotnet-restore")	
-	.Does(() => 
-	{
-		DotNetCoreBuild("./Valit.sln", new DotNetCoreBuildSettings 
-		{
-			Configuration = configuration,
-			MSBuildSettings = new DotNetCoreMSBuildSettings
-			{
-				TreatAllWarningsAs = MSBuildTreatAllWarningsAs.Error
-			}
-		});
-	});
+        .IsDependentOn("dotnet-restore")	
+        .Does(() => 
+        {
+                DotNetCoreBuild("./Valit.sln", new DotNetCoreBuildSettings 
+                {
+                        Configuration = configuration,
+                        MSBuildSettings = new DotNetCoreMSBuildSettings
+                        {
+                                TreatAllWarningsAs = MSBuildTreatAllWarningsAs.Error
+                        }
+                });
+        });
 
 Task("run-xunit-tests")	
-	.IsDependentOn("dotnet-build")
-	.Does(() => 
-	{
-		var settings = new DotNetCoreTestSettings
+        .IsDependentOn("dotnet-build")
+        .Does(() => 
+        {
+                var settings = new DotNetCoreTestSettings
         {
- 			Configuration = configuration
+                        Configuration = configuration
         };
 
-		DotNetCoreTest("./tests/Valit.Tests/Valit.Tests.csproj", settings);
-	});	
+                DotNetCoreTest("./tests/Valit.Tests/Valit.Tests.csproj", settings);
+        });	
 
 Task("Default")
-	.IsDependentOn("run-xunit-tests");
+        .IsDependentOn("run-xunit-tests");
 
 RunTarget(target);

build.ps1

@@ -156,7 +156,7 @@ if(-Not $SkipToolPackageRestore.IsPresent) {
     # Check for changes in packages.config and remove installed tools if true.
     [string] $md5Hash = MD5HashFile($PACKAGES_CONFIG)
     if((!(Test-Path $PACKAGES_CONFIG_MD5)) -Or
-      ($md5Hash -ne (Get-Content $PACKAGES_CONFIG_MD5 ))) {
+    ($md5Hash -ne (Get-Content $PACKAGES_CONFIG_MD5 ))) {
         Write-Verbose -Message "Missing or changed package.config hash..."
         Remove-Item * -Recurse -Exclude packages.config,nuget.exe
     }

src/Valit/CompleteValitStrategy.cs

@@ -1,8 +1,8 @@
-namespace Valit
+namespace Valit
 {
     public class CompleteValitStrategy : IValitStrategy
     {
-        public void Fail<TObject>(IValitRule<TObject> rule, IValitResult result, out bool cancel) 
+        public void Fail<TObject>(IValitRule<TObject> rule, IValitResult result, out bool cancel)
             where TObject : class
         {
             cancel = false;

src/Valit/Errors/ValitRuleError.cs

@@ -1,24 +1,28 @@
+using System;
+
 namespace Valit.Errors
 {
     internal class ValitRuleError
     {
-        public string Message  { get; }
+        private readonly Func<string> _messageFunc;
+        public string Message => _messageFunc();
         public int? ErrorCode { get; }
 
-        private ValitRuleError(string message)
+        private ValitRuleError(Func<string> messageFunc)
         {
-            Message = message;
+            _messageFunc = messageFunc;
         }
 
         private ValitRuleError(int errorCode)
         {
             ErrorCode = errorCode;
+            _messageFunc = () => string.Empty;
         }
 
-        public static ValitRuleError CreateForMessage(string message)
-            => new ValitRuleError(message);
+        public static ValitRuleError CreateForMessage(Func<string> messageFunc)
+            => new ValitRuleError(messageFunc);
 
         public static ValitRuleError CreateForErrorCode(int errorCode)
-            => new ValitRuleError(errorCode);   
+            => new ValitRuleError(errorCode);
     }
-}
+}

src/Valit/Exceptions/SemanticExceptions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace Valit.Exceptions
 {
@@ -8,6 +8,6 @@ public static ValitException NullDereferenced(string message)
             => throw new ValitException(message, new ArgumentNullException());
 
         public static ValitException NullDereferenced()
-          => throw new ValitException("Null dereferenced", new ArgumentNullException());
+        => throw new ValitException("Null dereferenced", new ArgumentNullException());
     }
 }

src/Valit/Exceptions/ValitExceptionExtensions.cs

@@ -22,4 +22,4 @@ internal static void ThrowIfNull<T>(this T @object, string message)
             }
         }
     }
-}
+}

src/Valit/Exceptions/ValitExceptionMessages.cs

@@ -3,6 +3,6 @@ namespace Valit.Exceptions
     internal static class ValitExceptionMessages
     {
         public static string NullRule => "Valit rule is null";
-        public static string NullPredicate => "Given predicate is null"; 
+        public static string NullPredicate => "Given predicate is null";
     }
-}
+}