fix: revert Grid to async rendering #273
Open
+145
−104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrapping renderers in flushSync doesn't guarantee that the DOM will be updated synchronously. React may still defer it to a micro task if flushSync was called while rendering was already in progress, which is explained in the currently suppressed warning:
When there are many deferred sync renderers that in turn trigger some async renderers, it can create race conditions that React misinterprets as a possible infinite loop:
This warning is particularly common in AutoGrid where a mix of sync (GridColumn) and async (Select) renderers is used. This PR reverts Grid to async rendering, which resolves the maximum depth warning and also improves performance. However, GridPro continues to use sync rendering because its web component currently requires the editor to render synchronously.
Fixes #255
Type of change