Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove installAutoSignalTracking from signals core (#2818) (CP: 24.5) #2859

Open
wants to merge 4 commits into
base: 24.5
Choose a base branch
from

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Anton Platonov <[email protected]>
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until this is released with a next 24.6 alpha before picking.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.5@3d096ab). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.5    #2859   +/-   ##
=======================================
  Coverage        ?   92.30%           
=======================================
  Files           ?       81           
  Lines           ?     2689           
  Branches        ?      689           
=======================================
  Hits            ?     2482           
  Misses          ?      156           
  Partials        ?       51           
Flag Coverage Δ
unittests 92.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants