Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add a new implementation of @vaadin/hilla-lit-form #2620

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Jul 25, 2024

No description provided.

@Lodin Lodin added the hilla Issues related to Hilla label Jul 25, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the m object declaration to a separate file because of the value method. I need it to be overloaded but overloading the object's method is impossible in TS, it's possible only for classes and functions. So I thought that it could be a good idea to make a module with bare functions that could be collected and exported as a single default object.

The drawback of this solution is that I can no longer use the reserved keyword as a name of the function. So, I renamed enum function to enumeration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I found that I can export it using export { enumeration as enum } which removes the drawback

Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant