fix: hide the grid-pro editor component until updated #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix/grid-pro-custom-editor-old-value-flashing
branch
from
828c419
to
2ffcf57
Compare
tomivirkki
force-pushed
the
fix/grid-pro-custom-editor-old-value-flashing
branch
from
2ffcf57
to
e7fd908
Compare
|
tomivirkki
commented
Nov 15, 2024
Comment on lines
+18
to
+23
| if (editor.__itemKey !== itemKey) { | ||
| // This is an outdated call that can occur if the user starts editing a cell, | ||
| // and quickly starts editing another cell on the same column before the editor | ||
| // is unhidden for the first cell. | ||
| return; | ||
| } |
There was a problem hiding this comment.
Couldn't find a way to test this in an IT. Here's the issue it fixes:
Kapture.2024-11-15.at.09.29.28.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes GridPro apply the "loading-editor" attribute on the web component while a custom editor component is still being loaded.
Kapture.2024-11-14.at.16.49.01.mp4
Fixes vaadin/web-components#2550
Depends on vaadin/web-components#8156
Type of change
Bugfix