-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages to resolve dependency conflicts after vulnerabilities. #1
Open
hermann77
wants to merge
15
commits into
vaadin-learning-center:master
Choose a base branch
from
hermann77:update-packages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update packages to resolve dependency conflicts after vulnerabilities. #1
hermann77
wants to merge
15
commits into
vaadin-learning-center:master
from
hermann77:update-packages
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tasks - mark task as completed - filter task list: all, active, completed
This reverts commit 505d333.
This reverts commit 711fda9.
…bilities fixes." This reverts commit c79b57f.
This reverts commit 5e6dc32.
This reverts commit 844a041.
This reverts commit b3f40d4.
This reverts commit 51ff96b.
… fixes. (cherry picked from commit c79b57f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I ran
npm audit fix
I got package dependency conflicts.So I installed all the packages in terminal:
npm install @babel/core @babel/plugin-syntax-dynamic-import @babel/preset-env babel-loader babel-preset-minify webpack webpack-cli webpack-dev-server webpack-merge workbox-webpack-plugin clean-webpack-plugin copy-webpack-plugin css-loader html-webpack-plugin mini-css-extract-plugin style-loader --legacy-peer-deps --save-dev
npm install --save lit-element
and
npm install --save @vaadin/vaadin-text-field @vaadin/vaadin-button @vaadin/vaadin-checkbox @vaadin/vaadin-radio-button
The webpack configs had to be updated regarding new APIs (webpack-merge, copy-webpack-plugin).
Please check especially 'from' 'to' options on
CopyWebpackPlugin
(withoutflatten
option). I'm very new in frontend/JS/webpack etc. :-).P.S. in package.json I didn't change
--env.mode production
to--env mode=production
yet.