[DAR-4305][External] Cancel push
operations if there are no valid files to upload, and correctly remove invalid files
#944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are 2 minor issues that were released with multi-file
push
in 1.0.10:LocalFile
objects. This leads to duplicate warningsSolution
LocalFile
to be removed if it hasn't already been added to the list of local files to be removed as a result of being tied to aMultiFileItem
ValueError
if there are noMultiFileItem
orLocalFile
objects left to upload after pruningChangelog
Improved error messaging when attempting to upload duplicate files