[DAR-4299][External] Allow import of NifTI annotations to dataset items with >1 slot #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorfmanrobert
approved these changes
Oct 11, 2024
darwin/importer/importer.py
Outdated
| @@ -2118,9 +2118,10 @@ def _display_slot_warnings_and_errors( | |||
| If there are any warnings generated and the annotation format is not Darwin JSON 2.0 | |||
There was a problem hiding this comment.
update this doc as well probably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In darwin-py 1.0.4 as part of DAR-2981, we prevented non-Darwin JSON 2.0 annotations from being imported to dataset items with >1 slot. This makes sense, except in the case of NifTI annotations, where we do want to allow users to import annotations to multi-slotted items
Therefore this ticket adds
niftito the list of supported multi-slotted formats. No other format should be supported at the time of this ticketSolution
This ticket adds
niftito the list of annotation formats that allow import to multi-slotted dataset itemsChangelog
Allow import of
niftiannotations to multi-slotted dataset items