[DAR-3579][External] Resolved legacy NifTI annotation import blocker #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Work introduced in darwin-py 1.0.4 introduced a bug when importing NifTI annotations in the using the legacy method. When doing this, we turn the importer into a partial function. In 1.0.4 we introduced a function that checks the format of the importer. However, it does not work with partial functions, resulting in:
Solution
Allow
_get_annotation_format()
to work with partial functions. This is temporary, and we can remove it in a future version when we have finished migrating NifTI annotation imports from the legacy method to the new methodChangelog
Resolved bug with legacy NifTI annotation imports