Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V7-3952] Support multi array coco segmentation import #511

Closed
wants to merge 2 commits into from

Conversation

simedw
Copy link
Collaborator

@simedw simedw commented Jan 9, 2023

In coco a segmentation can have more than polygon (in those cases it's an array of arrays of points), right now we are only importing the first element. This PR changes the logic to import all of them.

@linear
Copy link

linear bot commented Jan 9, 2023

V7-3952 Support multi array coco segmentation imports

Currently we are silently dropping any extra list of points in coco

@simedw simedw requested a review from owencjones January 9, 2023 10:55
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bit worried that it didn't break any unit tests, so I'll add a ticket to write them.

@JBWilkie
Copy link
Collaborator

JBWilkie commented Jan 2, 2025

Closing in favour of #989 which accomplishes the same goal

@JBWilkie JBWilkie closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants