Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uyuni proxy sync #9439
Fix uyuni proxy sync #9439
Changes from 2 commits
d70dd8d
c1bbe74
3388870
92bd67a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The channels synchronized seems correct, but.. I wonder at which point we include the correct repository for the mgr-tools (in particular mgrpxy) during the CI.
I guess... we only do it on sumaform, and we rely on it, right? If that's the case, maybe it gonna be good a comment somewhere in this feature to explain that we skip that step because we do directly on deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done during combustion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in combustion we might be passing Stable or Master as repos, but... not the one coming from the MIs, as far as I know we don't handle MI injections in combustion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the repositories from additional_repository variable ?
We do now add those repositories into combustion: https://github.com/uyuni-project/sumaform/blob/addeb4382c1c77c2e84f8e7644d66319fa28361e/backend_modules/libvirt/host/combustion#L97C1-L105C5
That what trigger me to open this issue: https://github.com/SUSE/spacewalk/issues/25609