Fix ubuntu 2004 reposync issue and 2204 reposync issue

[maximenoel8]

What does this PR change?

Fix ubuntu synchronization issues during BV uyuni reposync stage.

Errors

uyuni-bv-master-server:~ # mgrctl exec -i 'spacewalk-common-channels -u admin -p admin --list' | grep ubuntu-2204-pool-amd64-uyuni
 ubuntu-2204-pool-amd64-uyuni: amd64-deb

GUI diff

No difference.

• DONE

Documentation

• No documentation needed: only internal and user invisible changes

• DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

• No tests: already covered

• DONE

Links

Port :

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_lint_checkstyle"
• Re-run test "java_pgsql_tests"
• Re-run test "ruby_rubocop"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9333/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9333/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[Bischoff]

spotted inconsistency

[Bischoff]

below (line 1646) and above (line 448) it has a dot

[mcalmer]

AFAIK this inconsistency is real and exists. Please check spacewalk-common-channels.ini .
The Community wanted it

[Bischoff]

I'm not speaking about the inconsistency between 2204 and 24.04.

I'm speaking about the inconsistency between ubuntu-2404-pool-amd64-uyuni and ubuntu-24.04-pool-amd64-uyuni in this file.

[maximenoel8]

So this new name for 2404 is correct @mcalmer ?

[mcalmer]

Not sure. This is the definition we have in spacewalk-commons-channel.ini

[ubuntu-2404-pool-amd64-uyuni]
label     = ubuntu-24.04-pool-amd64-uyuni
checksum  = sha256
archs     = amd64-deb
repo_type = deb
name      = Ubuntu 24.04 LTS AMD64 Base for Uyuni
gpgkey_url =
gpgkey_id =
gpgkey_fingerprint =
repo_url  = http://localhost/pub/repositories/empty-deb/?uniquekey=2404-uyuni

as you see the section name has no "dot", while the channel label which will be generated has a "dot".
So it depends what you define in your structures. Is it the channel label or the value you provide to spacewalk-common-channel command?

[maximenoel8]

It's the value from spacewalk-common-channel for the others, in the testsuite, they have no dots.

[maximenoel8]

In spacewalk-commons-channel.ini I can see 20.04, 22.04 and 24.04 have the same description.

[Bischoff]

if all 3 have no dots in spacewalk-common-channels.ini, then current modified PR is correct. Approving.

[Bischoff]

see my comment

[Bischoff]

if all 3 have no dots in spacewalk-common-channels.ini, then current modified PR is correct. Approving.