separate debug symbols into a dbg file #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaevil
reviewed
Aug 12, 2024
isaevil
reviewed
Aug 19, 2024
src/tbb/CMakeLists.txt
Outdated
| @@ -126,6 +126,21 @@ target_link_libraries(tbb | |||
| ${TBB_COMMON_LINK_LIBS} | |||
| ) | |||
|
|
|||
| #strip symbols to a separate dbg file | |||
There was a problem hiding this comment.
Suggested change
| #strip symbols to a separate dbg file | |
| # Strip debug symbols into a separate .dbg file |
isaevil
approved these changes
Aug 19, 2024
| @@ -126,6 +126,25 @@ target_link_libraries(tbb | |||
| ${TBB_COMMON_LINK_LIBS} | |||
| ) | |||
|
|
|||
| # Strip debug symbols into a separate .dbg file | |||
| if(TBB_LINUX_SEPARATE_DBG) | |||
| if(NOT CMAKE_BUILD_TYPE STREQUAL "release") | |||
There was a problem hiding this comment.
Should we strip it for debug configuration?
There was a problem hiding this comment.
The debug symbols will not be stripped in any default configuration. If user set the BUILD_TYPE='debug' or relwithdebinfo and explicitly set the TBB_LINUX_SEPARATE_DBG switch, then the symbols get stripped to a different file and linked to binary. Whereas when BUILD_TYPE is 'release' the .dbg file has only the linkage information and hence creation of .dbg is avoided.
kboyarinov
pushed a commit
that referenced
this pull request
Oct 1, 2024
* separate debug symbols into a separate .dbg file when TBB_LINUX_SEPARATE_DBG is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a comprehensive description of proposed changes
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information