Update the CODEOWNERS list with owners for include headers. #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelkumbrasev
previously approved these changes
Jun 28, 2024
kboyarinov
reviewed
Jun 28, 2024
Comment on lines
+8
to
+9
| /oneTBB/include/oneapi/tbb/concurrent_* @kboyarinov | ||
| /oneTBB/include/oneapi/tbb/flow_graph* @kboyarinov |
There was a problem hiding this comment.
Should internal headers also be added here?
As far as I understand, this list would be used by GitHub to better suggest reviewers for the files and if only internals would be affected, it may also be useful.
There was a problem hiding this comment.
I presume you're talking about the headers in folder "detail" - Updated that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the CODEOWNERS list with owners for include headers.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information