Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable warning about the Intel Classic Compiler deprecation #1378

Merged
merged 2 commits into from
May 6, 2024

Conversation

timmiesmith
Copy link
Contributor

Description

The checks added in #1347 to disable WAITPKG support when it isn't available added a compile line to extract the assembler version -- https://github.com/oneapi-src/oneTBB/blob/377e6c3b1719f8cc7b68f9d0939e652d7e3bf776/cmake/compilers/GNU.cmake#L51. If the Intel Classic Compiler is set as the compiler it will emit a warning as the first line of output that it is deprecated, causing the subsequent version number extraction to fail. This PR adds a flag to silence the warning.

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

…ler deprecation to allow the version number to be correctly extracted.
…p regex to remove text before GNU version information.
@timmiesmith timmiesmith merged commit 762b8af into master May 6, 2024
22 checks passed
@timmiesmith timmiesmith deleted the timmiesm/squash-warning branch May 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants