Improve machine_pause on arm64 #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pavelkumbrasev <[email protected]>
pavelkumbrasev
requested review from
aleksei-fedotov,
dnmokhov,
sarathnandu and
isaevil
pavelkumbrasev
deleted the
dev/pavelkumbrasev/improve_arm64_loop_backoff
branch
sarathnandu
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: pavelkumbrasev <[email protected]> (cherry picked from commit 3420fb9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On arm64
isb(instruction synchronization barrier) is better to use than yield in a spin loop. Theyieldinstruction is anop. Theisbinstruction puts the processor to sleep for some short time by flushing the pipeline.isbis a good equivalent to the pause instruction onx86.Rust implementation + performance analysis: link
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information