Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating contents to write permissions to allow commit to be created #1364

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

timmiesmith
Copy link
Contributor

Description

Limiting write permissions to pages is insufficient to deploy pages. Allowing contents to be written is needed to allow git commits in the pages deploy job.

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@omalyshe

Other information

The comment on https://stackoverflow.com/a/77412363 points to other GitHub users experiencing the issue.

@timmiesmith timmiesmith requested a review from omalyshe April 24, 2024 15:53
Copy link
Contributor

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmiesmith timmiesmith merged commit 4f913ce into master Apr 24, 2024
20 of 21 checks passed
@timmiesmith timmiesmith deleted the timmiesm/pages-permissions branch April 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants