Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase yields multiplier on APPLE platforms #1356

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Increase yields multiplier on APPLE platforms #1356

merged 2 commits into from
Apr 24, 2024

Conversation

sarathnandu
Copy link
Contributor

@sarathnandu sarathnandu commented Apr 22, 2024 •
edited
Loading

Description

The yield multiplier for MacOS was set 10 times less than other Linux/Win platforms. This was done due to high cost of sched_yield in macOS. Latest experiments on Mac system indicate this can be made to be the same multiplier (100) across all platforms.

Type of change

  • [x ] bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • [x ] not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • [x ] not needed

Breaks backward compatibility

  • Yes
  • [x ] No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

pavelkumbrasev
pavelkumbrasev reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@pavelkumbrasev pavelkumbrasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix copyright

@sarathnandu
Update Copyright year.
0ec179a 
Signed-off-by: sarathnandu <[email protected]>
pavelkumbrasev
pavelkumbrasev approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@pavelkumbrasev pavelkumbrasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dnmokhov
dnmokhov approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@dnmokhov dnmokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarathnandu sarathnandu merged commit 791701a into master Apr 24, 2024
22 checks passed
@sarathnandu sarathnandu deleted the dev/pavelkumbrasev/increase_block_time_on_mac branch April 24, 2024 15:53
sarathnandu added a commit that referenced this pull request May 8, 2024
@sarathnandu
Increase yields multiplier on APPLE platforms (#1356)
2f9a944 
* Increase yields multiplier on APPLE platforms

Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: sarathnandu <[email protected]>
Co-authored-by: pavelkumbrasev <[email protected]>
(cherry picked from commit 791701a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnmokhov dnmokhov dnmokhov approved these changes

@pavelkumbrasev pavelkumbrasev pavelkumbrasev approved these changes

@JhaShweta1 JhaShweta1 Awaiting requested review from JhaShweta1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarathnandu @pavelkumbrasev @dnmokhov