Correct MyHashCompare example in concurrent_hash_map page
#1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirements from [HashCompare](https://spec.oneapi.io/versions/latest/elements/oneTBB/source/named_requirements/containers/hash_compare.html) state that `hash` and `equals` should be regular class functions as opposed to `static`, and have `const` modifiers at the end. The example in `concurrent_hash_map.h` isn't consistent with this (or with the [More on HashCompare](https://oneapi-src.github.io/oneTBB/main/tbb_userguide/More_on_HashCompare.html) page). Signed off by: Daniel Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements from HashCompare state that
hashandequalsshould be regular class functions as opposed tostatic, and haveconstmodifiers at the end. The example inconcurrent_hash_map.hisn't consistent with this (or with the More on HashCompare page).Signed off by: Daniel Bashir [email protected]
Fixes # - N/A
Type of change
Tests
Documentation
Breaks backward compatibility
Notify the following users
N/A
Other information
N/A