Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct behavior on deactivated permit #1308

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

isaevil
Copy link
Contributor

@isaevil isaevil commented Feb 1, 2024

Description

new concurrency value may still not be 0 even if permit was deactivated (since there was no other demand for resources). This patch forces new concurrency to 0 when permit is deactivated.

Fixes # - issue number(s) if exists

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Signed-off-by: Isaev, Ilya <[email protected]>
pavelkumbrasev
pavelkumbrasev previously approved these changes Feb 2, 2024
@pavelkumbrasev
Copy link
Contributor

Please provide a comment why we enforce concurrency

Signed-off-by: Isaev, Ilya <[email protected]>
Co-authored-by: Pavel Kumbrasev <[email protected]>
@omalyshe omalyshe merged commit 627cac6 into master Feb 5, 2024
19 checks passed
@omalyshe omalyshe deleted the dev/isaevil/tcm-integration-fix branch February 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants