Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file for tbbmalloc(_proxy) #1296

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Jan 18, 2024

Description

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Code owners are not automatically requested to review draft pull requests.

Fixes # - N/A

  • - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@ldorau @lplewa

Other information

Code owners are automatically requested for review when someone opens
a pull request that modifies code that they own. Code owners are
not automatically requested to review draft pull requests.

Signed-off-by: Krzysztof Filipek <[email protected]>
@KFilipek KFilipek self-assigned this Jan 18, 2024

# More details are here: https://help.github.com/articles/about-codeowners/

src/tbbmalloc @ldorau @lplewa @kfilipek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following error message on both lines 6-7
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose @ldorau does not exist ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose @ldorau does not exist ;-)

Maybe you don't have write permissions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems so, how can I verify that?

Copy link
Contributor Author

@KFilipek KFilipek Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omalyshe, as I saw, @ldorau was added to the group and then:
image

Copy link
Contributor

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lplewa lplewa merged commit df7306c into uxlfoundation:master Mar 11, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants