Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Fix install step #616

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[cmake] Fix install step #616

merged 1 commit into from
Dec 9, 2024

Conversation

Rbiessy
Copy link
Contributor

@Rbiessy Rbiessy commented Dec 5, 2024

Description

  • Fix path to MKLConfig.cmake when running the install step
  • Minor fix of call to add_deprecated_library
    • The extra argument was ignored but it's best to remove it to avoid confusion

Checklist

All Submissions

  • [N/A] Do all unit tests pass locally? Attach a log.

@Rbiessy
[cmake] Fix install step
1919cfc 
* Fix path to MKLConfig.cmake
* Minor fix of call to add_deprecated_library
@Rbiessy Rbiessy requested a review from a team as a code owner December 5, 2024 12:42
@Rbiessy Rbiessy requested a review from s-Nick December 5, 2024 12:49
@Rbiessy Rbiessy merged commit 40b7e0a into uxlfoundation:develop Dec 9, 2024
7 checks passed
@Rbiessy Rbiessy deleted the romain/fix_cmake_install branch December 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhsieh-intel dnhsieh-intel dnhsieh-intel approved these changes

@s-Nick s-Nick s-Nick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rbiessy @s-Nick @dnhsieh-intel