Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add editable page numbers #387

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[Feature] Add editable page numbers #387

wants to merge 1 commit into from

Conversation

ChinemeremChigbo
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo commented Dec 10, 2024 •
edited
Loading

Notion ticket link

Permit holder and request page scroll enhancement

Implementation description

  • Adds a text input field to the Pagination component so a page can be specified by typing
  • I chose to do the validation upon keyboard input rather than upon hitting of the enter key. I thought this might be less confusing for the user.
2024-12-09.19-42-12.mp4

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@ChinemeremChigbo ChinemeremChigbo changed the title Add editable page numbers [Feature] Add editable page numbers Dec 10, 2024
@ChinemeremChigbo ChinemeremChigbo requested review from a team and removed request for a team December 10, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChinemeremChigbo