[Improvement] Remove applicant deletion #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChinemeremChigbo Does this remove deletion for all permit holders? The requirement is to only remove for users who have completed applications. |
ChinemeremChigbo
force-pushed
the
remove-permit-holder-delete
branch
2 times, most recently
from
2c89e42 to
4be8bef
Compare
Ahh, Alas, I was confused by the Notion ticket description. I have modified this to only hide the deletion option for Applicant's whose mostRecentApplication's processing status is completed. |
ChinemeremChigbo
force-pushed
the
remove-permit-holder-delete
branch
from
4be8bef to
57e09d5
Compare
ChinemeremChigbo
changed the title
sherryhli
pushed a commit
that referenced
this pull request
Nov 18, 2024
Merged
sherryhli
added a commit
that referenced
this pull request
Nov 18, 2024
* [enhancement] Track application status to return to original tab in admin view (#372) * Track application status to return to correct tab * fixup! Track application status to return to correct tab * [Fix] Unsaved Doctor's Information (#374) * used values.doctorInformation instead of doctorInformation * using validated values for doctor's info * [Improvement] Add pagination controls to top of requests/permit holders tables (#376) * Add pagination to top of requests table * Add pagination to top of permit holders table * Add Vihaan to employees.ts (#379) * Add Braydent to employee.ts (#380) * broyston: updated stamp png to contain new address (#382) * Add phone number and addresses to request report (#383) * Remove applicant deletion (#377) --------- Co-authored-by: Jennifer Chen <[email protected]> Co-authored-by: Keane Moraes <[email protected]> Co-authored-by: Chinemerem <[email protected]> Co-authored-by: Brayden Royston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
[RCD] Modify User Deletion Feature
Implementation description
Permit_Holders_Before.mp4
Permit_Holders_After.mp4
Checklist
[Feature],[Improvement]or[Fix],