Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove npx from start script #348

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

sherryhli
Copy link
Member

Notion ticket link

N/A

Implementation description

Remove npx from start command, suspect this is causing an error on start up in staging

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@sherryhli sherryhli merged commit 21854dc into staging Feb 5, 2024
1 check passed
@sherryhli sherryhli deleted the sl/fix-start-script branch February 5, 2024 04:24
leogjhuang pushed a commit that referenced this pull request Feb 15, 2024
leogjhuang added a commit that referenced this pull request Feb 15, 2024
* [Improvement] Clarify lowercase extension requirement for POA form upload (#343)

* Change text on processing task 2 (#344)

* Remove holiday closure banner (#345)

* [Feature] Update ci.yml to add pending migrations to db (#339)

* Update ci.yml to add pending migrations to db

* Add .env file to CI

* Update ci.yml

* Update ci.yml

* Use longer URL

* Add to package.json instead

* revert ci.yml

* Re-add ci.yml

* Add space to yarn build

* Make title fit on one line (#347)

* [Fix] Remove npx from start script (#348)

* [Feature] Add AMEX (#346)

* Add Amex

* Add Amex to popoulate js file

* Update populate-db-09-13-21.ts

* [Fix] Revert init migration file and add new migration for AMEX paymenttype (#349)

* Revert paymenttype edit to init migration file

* Create migration to add AMEX paymenttype

* [Improvement] Change helper text for date of birth (#350)

* Change helper text for date of birth

* Remove text wrapper on DOB helper text

* [Feature] Add second payment method for permit requests (#338)

* Add second payment method types to schema

* Update application validation schema to allow second payment methods

* Change payment detail components to show second payment method

* Consider donations on second payment method in processing tasks

* Update data pipelines to generate accountant reports with second payment method included

* Update invoice and donation receipt with second payment method included

* Rename second payment method variables to improve clarity

* Add migration for second payment method

---------

Co-authored-by: Sherry Li <[email protected]>
Co-authored-by: Chinemerem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants