[Improvement] Add Mail Lost Option as Replacement Reason #340
Conversation
|
It says that the Prettier linting has failed but I just ran it on my machine and this is what I get Furthermore on the general linting command I get this |
There was a problem hiding this comment.
Re: lint error
Seems related to the changes in the yarn.lock file - reverting back to the current version in staging fixes it. See #342
I had to add a migration using prisma migrate deploy that manually added another migration. I don't know if this is supposed to be done because there was only an init migration before me. Please check that this is valid
Migration looks good to me! For future reference the procedure is to run prisma migrate dev after any schema change.
For LOST,STOLEN and OTHER there are additional fields for information. Will I need to add additional fields for MAIL_LOST
Do you mean fields like lostTimestamp, stolenPoliceFileNumber, etc. in the schema? Not necessary if that's what you're referring to.
| onChange={() => { | ||
| setFieldValue('paymentInformation.processingFee', '0'); | ||
| }} | ||
| > | ||
| {'Mail Lost'} | ||
| </Radio> | ||
| <Radio | ||
| value={'OTHER'} |
There was a problem hiding this comment.
Just occurred to me that we need to discuss how to handle existing replacement applications that were created after #325, which mapped the OTHER enum to the displayed value of 'Mail Lost'. Once this is PR merged, any application using OTHER will show as 'Other' even if they were supposed to be 'Mail Lost'.
Let's discuss in Wednesday's meeting, can you please hold off on merging this PR (at least the frontend portion)?
kj3moraes
force-pushed
the
km-mail-lost-option
branch
from
e85a59d to
be5f9d6
Compare
…richmond-centre-for-disability into km-mail-lost-option
* initial commit for the mail lost option * changed the processing fee for mail lost * made the migrations for mail lost * reverted yarn lock to staging * initial commit for the mail lost option * changed the processing fee for mail lost * made the migrations for mail lost * reverted yarn lock to staging --------- Co-authored-by: Chinemerem <[email protected]>
* Add Sharujan to employees.ts (#360) * [Improvement] Add Mail Lost Option as Replacement Reason (#340) * initial commit for the mail lost option * changed the processing fee for mail lost * made the migrations for mail lost * reverted yarn lock to staging * initial commit for the mail lost option * changed the processing fee for mail lost * made the migrations for mail lost * reverted yarn lock to staging --------- Co-authored-by: Chinemerem <[email protected]> * Add $200 donation option (#355) * Add $200 donation option * Add $200 donation option * Update .env.sample with $200 donation product id --------- Co-authored-by: Chinemerem <[email protected]> * Change address from unit 842 to 968 (#361) * [Fix] Add AMEX as a second payment option (#362) * [Feature] Add receipt numbers to application reports (#363) * [Misc] Update README.md (#364) --------- Co-authored-by: Chinemerem <[email protected]> Co-authored-by: Keane Moraes <[email protected]> Co-authored-by: Sherry Li <[email protected]>
Notion ticket link
Add MAIL_LOST as a reason for replacement
Implementation description
Notes
prisma migrate deploythat manually added another migration. I don't know if this is supposed to be done because there was only an init migration before me. Please check that this is validChecklist
[Feature],[Improvement]or[Fix],