-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edmond/llsc 27 Data Seeding (Matching) #9
base: rohan-edmond-mayank/matching-algo
Are you sure you want to change the base?
Edmond/llsc 27 Data Seeding (Matching) #9
Conversation
…d/llsc-27-data-seeding
…d/llsc-27-data-seeding
…m/uwblueprint/llsc into edmond/llsc-27-data-seeding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments for testing.
@@ -1,7 +1,11 @@ | |||
import argparse | |||
import sys | |||
from llsc.backend.matching.data.seeder.data_seeder import Seeder | |||
from config import OUTPUT_FORMAT_CHOICES, FILE_PATH_REQUIRED_FORMATS | |||
from backend.matching.data.seeder.data_seeder import Seeder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try to make this backend
folder centric, or you can use local file paths .seeder.data_seeder
. I can't access this from backend
iirc
OUTPUT_FORMAT_CHOICES, | ||
OPTIONS_FOR_DATA, | ||
FILE_PATH_REQUIRED_FORMATS, | ||
) | ||
|
||
|
||
class CLI: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this a pdm script command so we can access faker
and pandas
packages. You can add this in backend/pyproject.toml
under [tool.pdm.scripts]
as matching: python3 matching/data/data_generator
Notion ticket link
LLSC-27 Create DB Seeds
Implementation description
data seeder for the matching algorithm. Make classes orignally for the form (to make it more scalable if needed), and CLI to get the data towards the target data fromat.
NOTE: upserting the data to the DB is not complete yet; labeled todos
NOTE: this isnt being merged to main; instead its being merged to the main matching branch (aka this isnt a main-breaking pr)
NOTE: need to make sure the pdm recognizes these packages added and fast api can boot up
Steps to test
Finalized and tested the seeder. The cmd to run atm are:
cd
to thebackend
dir and then runpython -m backend.matching.data.data_generator volunteer 10 json --file_path ~/Downloads/outputt.test
there is a CLI with approp help cmds (HERE IS FOR FILE PATH SPECIFIED)
if no file path we can do:
What should reviewers focus on?
Checklist