Panel Data #36
Panel Data #36
Conversation
Python script to upload panel data to PostgreSQL database
Added README and a couple comments
There was a problem hiding this comment.
@jinayang15 Great job getting this working. I had a couple of comments on this regarding using SQLAlchemy and a more abstract code structure with functions and classes.
If you feel it is too much of a hassle then let me know, but I feel it could be a good structure to work with.
Also please fix the linting issues. Most of them can be fixed by running black panels-data.py (installation here: https://github.com/psf/black?tab=readme-ov-file#installation-and-usage)
Thank you!
- Changed to work as a function and abstracted the queries to allow Solar Panel to work as a class
There was a problem hiding this comment.
@jinayang15 Thank you for taking care of this. I have mentioned a couple of things you need to change. Further, remove the old panels_data.py file and move the requirements.txt and README to the same folder as the new panels_data.py file. Also if you have the database credentials, try adding it and giving us a photo of the data being there. If you don't have let us know and we can check that out.
Also please fix the linting issues using python-black and for further details check the logs of the job that is failing. Let me know if you face any trouble and I can help you out with that.
This is what the data looks like in the database. I think the linting issues should be fixed? If there are still problems with that, I may need some help. |
There was a problem hiding this comment.
@jinayang15 From our previous discussion with Forest, please use the brochure linked in the confluence page to access the dimensions and other data and add that in as well. Also please do not push .DS_Store files to the repository. Thanks :)
Just to clarify, what specific data would you like me to add? Do we want width and height or just area? Also, is there any other information that would be useful? |
|
@jinayang15 You can push height, width and surface area. More data wouldn't hurt. That should be good. Thanks! |
This is what the table looks like now. Let me know if there is anything else I should change!
|
There was a problem hiding this comment.
@jinayang15 LGTM! The data looks good, thanks for pushing this and checking out all of my concerns.
If the workflow passes, we can merge the PR in.
There was a problem hiding this comment.
@jinayang15 I think you need to fix some linting issues, so please do that first! Think they would be fixed by running the black formatter, but if you are unable to figure out, let me know and I can help you out.
Shoot, I forgot about it again. Should be good now! |
There was a problem hiding this comment.
@jinayang15 We can merge the PR in now
@jinayang15 I think you need to fix some linting issues, so please do that first! Think they would be fixed by running the black formatter, but if you are unable to figure out, let me know and I can help you out.
Shoot, I forgot about it again. Should be good now!
Don't worry its all good!
Uploads solar panel data to PostgreSQL database