Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative way to fetch recordings #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 8, 2024

Pull Request Description: Alternative Way to Fetch Recordings

Motivation

The current implementation of the KerberosVault class only allows fetching media directly from the storage service. However, in some scenarios, it is more efficient or necessary to retrieve a URL to the media file and then download the media separately. This pull request introduces an alternative method for fetching recordings, providing more flexibility in how media is retrieved and processed.

Changes Introduced

  1. New GitHub Actions Workflows:

    • Added .github/workflows/create-pr.yaml to automate the building and pushing of Docker images when a pull request is created or synchronized.
    • Added .github/workflows/pr-description.yml to autofill the PR description using OpenAI, ensuring consistency and saving time.
  2. KerberosVault Class Enhancements:

    • Introduced retrieve_media_url method: Fetches the URL of the media file from the storage service.
    • Introduced retrieve_media_through_url method: Uses the URL fetched by retrieve_media_url to download the media file.
    • Code formatting improvements for better readability and maintenance.

Why This Improves the Project

  • Increased Flexibility: Provides alternative methods for fetching media, accommodating different use cases and improving the versatility of the KerberosVault class.
  • Automated Workflow: Enhances CI/CD processes by automating Docker builds and PR descriptions, reducing manual effort and potential errors.
  • Code Quality: Improves code readability and maintainability through better formatting and organization.

By introducing these changes, the project becomes more robust, flexible, and easier to maintain, ultimately leading to a more efficient development process and better end-user experience.

@cedricve cedricve added bug Something isn't working enhancement New feature or request labels Oct 8, 2024
@cedricve cedricve requested a review from KilianBoute October 8, 2024 14:53
@cedricve cedricve self-assigned this Oct 8, 2024
@KilianBoute
Copy link
Member

Is the failed check normal for now or is this actually still in progress?

@cedricve
Copy link
Member Author

cedricve commented Oct 9, 2024

still WIP, I assigned you to quickly. Will remove you.

@cedricve cedricve removed the request for review from KilianBoute October 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants